Suggestions
Modify milestone tax consequence UI
The current milestone tax consequence interface requires the user to completely specify the tax config that will take effect at that milestone. I find this un-intuitive, and often make mistakes by editing a plan’s base tax config and forgetting that I have to find and update the config of each milestone with a tax consequence.
I think it would be an improvement if the tax consequence UI allowed the user to instead indicate what aspects of the tax config were changing at that milestone, and PL then changed only those settings when the milestone hits.
For instance, the current UI could remain, but each option (TCJA, medicare, etc) is greyed out until the user selects it, and only those items that the user edits are applied when the milestone hits).
I think the most intuitive logic would be that the tax config in effect at a given year is computed by starting with the base plan configuration and applying each achieved milestone’s changes, in chronological order. This would require a resolution to the ambiguity created when two milestones happen simultaneously, but PL has that issue already, I suppose.
Alternately, PL could use the base plan and the most recent milestone only, but I suspect that will be counter to most users’ expectations.
I will post a topic about this on the discord.